Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Dotty workflow of 2024-02-24 failed #19772

Open
github-actions bot opened this issue Feb 24, 2024 · 7 comments · May be fixed by #19794
Open

Nightly Dotty workflow of 2024-02-24 failed #19772

github-actions bot opened this issue Feb 24, 2024 · 7 comments · May be fixed by #19794

Comments

@github-actions
Copy link
Contributor

See https://github.com/lampepfl/dotty/actions/runs/8027770056

@hamzaremmal
Copy link
Member

hamzaremmal commented Feb 24, 2024

This is an issue with an SSL Certificate with one of the URLs used in the tests. You can reproduce it with the following :

import java.net.{URL, HttpURLConnection}

val url = new URL("https://s3.amazonaws.com/onnx-model-zoo/squeezenet/squeezenet1.1/squeezenet1.1.onnx")
val conn = url.openConnection()
conn.connect()

Also, this link is not used anymore in the original project. We should probably update dotty-staging/onnx-scala too. (I will not do it myself as I'm not a 100% familiar with the procedure)

PS: I would be very interested to learn more about the procedure, whoever picks this one up, I would be grateful if you contact me prior to fixing this :-)

@odersky
Copy link
Contributor

odersky commented Feb 26, 2024

@anatoliykmetyuk According to Maintenance.md you are still the maintainer of CB. Can you take a look and/or find a successor who can take this on from now?

Everyone: If there's a blocker like this, it needs to be assigned to someone. @hamzaremmal's analysis is really useful, but there needs to be a follow-up.

@anatoliykmetyuk
Copy link
Contributor

I discussed it with @hamzaremmal, and he's happy to overtake CB from me. Thank you @hamzaremmal!

@hamzaremmal hamzaremmal self-assigned this Feb 26, 2024
@hamzaremmal
Copy link
Member

@anatoliykmetyuk and I will meet tomorrow so he can explain the procedure to me. Expect this to be fixed by then.

@anatoliykmetyuk anatoliykmetyuk removed their assignment Feb 26, 2024
anatoliykmetyuk added a commit to dotty-staging/dotty that referenced this issue Feb 26, 2024
@hamzaremmal
Copy link
Member

Since this is a blocker, I've disabled the test for now (See #19783)

@hamzaremmal hamzaremmal linked a pull request Feb 27, 2024 that will close this issue
@SethTisue
Copy link
Member

Should this ticket remain open?

@hamzaremmal
Copy link
Member

Yes, I'm currently doing some refactoring on the CB and I'll close it once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants