Consider nullable annotations in explicit nulls

[noti0na1]

The @NotNull and @NonNullable type annotations are currently used by explicit nulls to not nullify (or add flexible type to) a reference type from Java signatures.

In addition to these annotations, I suggest we also consider the @Nullable annotation. It indicates a value can indeed be null. In this case, we will always nullify the type (adding | Null), instead of adding a flexible type.

// in Java
@Nullable String f(String s)

// in Scala with explicit nulls currently
def f(s: (String)?): (String)?

// in Scala with explicit nulls considering the annotation
def f(s: (String)?): String | Null

A list of @Nullable annotations we may want to consider:

javax.annotation.Nullable
org.jetbrains.annotations.Nullable
org.jspecify.annotations.Nullable
...

[olhotak]

There is already some support for this (or was it disabled at some point?). See NotNullAnnots in Definitions.scala and uses of that. def hasNotNullAnnot in JavaNullInterop.

Oh, sorry, I misunderstood.

[noti0na1]

Not sure about the current status of Java ecosystem. I guess jspecify is the latest standard for this kind of annotations?

[olhotak]

Perhaps this could be a good introductory task for @HarrisL2

[noti0na1]

This is a list of annotations considered by Kotlin:
https://github.com/JetBrains/kotlin/blob/a9ff22693479cabd201909a06e6764c00eddbf7b/core/compiler.common.jvm/src/org/jetbrains/kotlin/load/java/JvmAnnotationNames.kt

We should update our existing list as well.

[rajRishi22]

Hi @noti0na1 , I want to work on this issue can you please assign me this one ?

[noti0na1]

Hi @rajRishi22 , feel free to work on this issue.

[noti0na1]

Reassign to @HarrisL2, since he is already working on this.

[HarrisL2]

Reassign to @HarrisL2, since he is already working on this.

Got it.