Skip to content

Semantic names not used in LambdaLift #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smarter opened this issue Apr 12, 2017 · 1 comment
Closed

Semantic names not used in LambdaLift #2246

smarter opened this issue Apr 12, 2017 · 1 comment

Comments

@smarter
Copy link
Member

smarter commented Apr 12, 2017

The semantic name PR broke compilation of scalatest, see #2233, the stacktrace is at https://gist.github.com/smarter/2b03b8fc57f7b8e4a027affe39b4426b and fails in LambdaLift. I'm not sure why, but I've noticed that LambdaLift defines the following method:

    private def newName(sym: Symbol)(implicit ctx: Context): Name =
      if (sym.isAnonymousFunction && sym.owner.is(Method, butNot = Label))
        (sym.name ++ NJ ++ sym.owner.name).freshened
      else sym.name.freshened

Which seems like it should be creating a semantic qualified name instead.

@odersky
Copy link
Contributor

odersky commented Apr 13, 2017

I don't think that's what it is. I think it rather has to do with #2216

odersky added a commit that referenced this issue Apr 21, 2017
Fix #2246: Use semantic names when freshening
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants