Skip to content

Dotty 0.4.0-RC1 shell scripts should detect Java 9 and stop with an error #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Oct 10, 2017 · 1 comment
Closed

Dotty 0.4.0-RC1 shell scripts should detect Java 9 and stop with an error #3304

smarter opened this issue Oct 10, 2017 · 1 comment
Assignees
@allanrenucci
Labels
area:infrastructure itype:enhancement prio:blocker

Comments

@smarter
Copy link
Member

smarter commented Oct 10, 2017

Dotty won't be compatible with Java 9 until #3138 is done. To avoid confusing people with weird errors, we should check the Java version in the shell script and ask people to use Java 8. To get the Java version use https://github.com/sbt/sbt-launcher-package/blob/master/src/universal/bin/sbt-launch-lib.bash
@smarter
Copy link
Member Author

smarter commented Oct 10, 2017

The actual check is at https://github.com/sbt/sbt-launcher-package/blob/master/src/universal/bin/sbt-launch-lib.bash#L183

allanrenucci added a commit to dotty-staging/dotty that referenced this issue Oct 11, 2017
@allanrenucci
Fix scala#3304: Launch script now requires Java 8
80ac419
liufengyun added a commit that referenced this issue Oct 12, 2017
@liufengyun
Merge pull request #3307 from dotty-staging/fix-#3304
c710052 
Fix #3304: Launch script now requires Java 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allanrenucci allanrenucci

Labels
area:infrastructure itype:enhancement prio:blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @allanrenucci