Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/reference] more fixes in Markdown files #11016

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

michelou
Copy link
Contributor

@michelou michelou commented Jan 6, 2021

Follow up of PR #10767, #10826, #10860, #10875 and #10953.

Fixes more issues found in Markdown files in docs/reference/, e.g.

Question: can I remove the following deprecated Markdown files ?!

reference/contextual/implicit-by-name-parameters.md
reference/contextual/import-delegate.md
reference/contextual/import-implied.md
reference/contextual/inferable-by-name-parameters.md
reference/contextual/inferable-params.md
reference/contextual/instance-defs.md
reference/contextual/query-types-spec.md
reference/contextual/query-types.md
reference/other-new-features/implicit-by-name-parameters.md

PS. The above changes can also be viewed in the PDF document scala3_reference.pdf (888 Kb) generated with Pandoc 2.11 in ~40 seconds.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @michelou !

Question: can I remove the following deprecated Markdown files ?!

reference/contextual/implicit-by-name-parameters.md
reference/contextual/import-delegate.md
reference/contextual/import-implied.md
reference/contextual/inferable-by-name-parameters.md
reference/contextual/inferable-params.md
reference/contextual/instance-defs.md
reference/contextual/query-types-spec.md
reference/contextual/query-types.md
reference/other-new-features/implicit-by-name-parameters.md

Good catch, they are obsolete, I think it's fine to remove.

@liufengyun liufengyun merged commit 437d02a into scala:master Jan 7, 2021
@michelou michelou deleted the scala3-docs branch January 7, 2021 12:54
b-studios added a commit to b-studios/docs.scala-lang that referenced this pull request Jan 8, 2021
PR scala/scala3#11016 removed some
old pages, which broke the CI of docs.scala-lang.org
@b-studios
Copy link
Contributor

Sorry for joining in late... the problem with removing obsolete files is that they may be linked on docs.scala-lang.org (blog posts, SIP minutes, ...) and contributors. But of course, it is a good idea to clean things up a bit.

b-studios added a commit to scala/docs.scala-lang that referenced this pull request Jan 8, 2021
PR scala/scala3#11016 removed some
old pages, which broke the CI of docs.scala-lang.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants