Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2941: Add regression test #11260

Merged
merged 1 commit into from
Jan 31, 2021
Merged

Fix #2941: Add regression test #11260

merged 1 commit into from
Jan 31, 2021

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Jan 31, 2021

Closes #2941 - fixed by #11192

liufengyun
liufengyun approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@liufengyun liufengyun merged commit 70a28f0 into scala:master Jan 31, 2021
@griggt griggt deleted the fix-#2941 branch January 31, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cyclic type involving LazyRef is not detected and crash in Pickler.
2 participants
@griggt @liufengyun