Load .tasty files from in-memory file systems too #11308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
in-memory-tasty
branch
from
e7f44c9 to
7586a43
Compare
smarter
reviewed
Feb 3, 2021
Comment on lines
920
to
921
| val tastyFileOrNull = classfile.container | ||
| .lookupName(classfile.name.stripSuffix(".class") + ".tasty", false) |
There was a problem hiding this comment.
Does this need to be a special-case just for virtual files or could this codepath also work for plain files?
There was a problem hiding this comment.
This should work for plain files too, I think. And using it there would run that code in the tests.
smarter
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to com-lihaoyi/Ammonite#1150.
This PR allows to load
*.tastyfiles from in-memory file systems (likedotty.tools.io.VirtualDirectory-based things) during compilation, rather than requiring them to exist on disk. This would be useful from Ammonite for example, that keeps the compiler output of previous compilation steps in memory.Not sure if or where I should add tests for that.