Fix TypeTest exhaustivity check
#12036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be later replaced with the generalized covering checks in #11186. |
Properly capture the semantics of `TypeTest` in the `Space` logic. `TypeTest[S, T].unapply` is equivalent to (and mostly used as) a `_: T` pattern and therefore covers all `T`. * Update the documentation to make this feature clearer * Fixes scala#12026 * Fixes scala#12020 * Improves scala#11541
nicolasstucki
force-pushed
the
fix-TypeTest-exhausivity-check
branch
from
f611fdc to
88de390
Compare
liufengyun
reviewed
Apr 10, 2021
| // If the scrutinee is not of type `S`, then we would already have an unchecked warning. | ||
| minus(a, params.head) | ||
| else | ||
| a // approximation |
There was a problem hiding this comment.
If the issues are really urgent to fix, I'd suggest extracting the code in #11186 (without introducing any annotations) and specialize the method covers instead. This way, we keep the logic in the base class general, which is a design invariant supposed to improve maintainability of the code.
There was a problem hiding this comment.
@liufengyun could you help me with that?
There was a problem hiding this comment.
No problem, I'll create a new PR to do that today.
|
Replaced with #12059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly capture the semantics of
TypeTestin theSpacelogic.TypeTest[S, T].unapplyis equivalent to (and mostly used as) a_: Tpattern and therefore covers allT.