Skip to content

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Apr 27, 2021

Users may see an extra Typed in the trees of patterns

Fixes #12221
Backported from #12200

@nicolasstucki nicolasstucki added this to the 3.0.x milestone Apr 27, 2021
@nicolasstucki nicolasstucki changed the title Backport more reflection fixes Backport more reflection fixes from #12200 Apr 27, 2021
@nicolasstucki nicolasstucki force-pushed the backport-reflection-fixes-2 branch from 1abf186 to 1ecb4a7 Compare April 27, 2021 11:53
Remove old workaround for `Unapply`.

Users may see an extra `Typed` in the trees of patterns

Fixes scala#12221
@nicolasstucki nicolasstucki force-pushed the backport-reflection-fixes-2 branch from 1ecb4a7 to 79cbafc Compare April 27, 2021 15:47
@nicolasstucki nicolasstucki changed the title Backport more reflection fixes from #12200 Fix internal definition of Unapply Apr 28, 2021
@nicolasstucki nicolasstucki marked this pull request as ready for review April 28, 2021 05:38
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 6b9ee58 into scala:master Apr 28, 2021
@nicolasstucki nicolasstucki deleted the backport-reflection-fixes-2 branch April 28, 2021 11:21
@Kordyjan Kordyjan modified the milestones: 3.0.0, 3.0.1 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency between reflect Typed and

3 participants