Correctly check experimental features #12672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When inlining: emit "experimental" error only when the feature in question is actually annotated as experimental - Compiler-wide: treat non-bootstrapped compiler as experimental-friendly. The motivation is to compile the standard library with experimental features enabled at all times. This change isn't supposed to introduce any experimental features leaks into stable builds since we do not publish non-bootstrapped compiler.
nicolasstucki
approved these changes
Jun 2, 2021
anatoliykmetyuk
pushed a commit
that referenced
this pull request
Jun 2, 2021
Correctly check experimental features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the feature in question is actually annotated as
experimental
experimental-friendly. The motivation is to compile
the standard library with experimental features enabled
at all times. This change isn't supposed to introduce any
experimental features leaks into stable builds since
we do not publish non-bootstrapped compiler.
This is supposed to fix the 3.0.1-RC1 release which failed due to broken experimental feature checks: https://github.com/lampepfl/dotty/runs/2717422630?check_suite_focus=true