Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs, change sidebar url property to page/index #13004

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

BarkingBad
Copy link
Contributor

No description provided.

@anatoliykmetyuk
Copy link
Contributor

Is this one ready for review?

@BarkingBad BarkingBad marked this pull request as ready for review July 12, 2021 07:39
@BarkingBad
Copy link
Contributor Author

@anatoliykmetyuk yes, I was waiting for pikinier to add his docs for snippet compiler, but appartenly he will do this in a separate PR then

@julienrf julienrf self-assigned this Jul 13, 2021
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the documentation! I suggest using a grammar checker (I’m personally happy with Grammarly) to catch most of the English mistakes, before submitting the PR for review.

docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
@julienrf julienrf removed their assignment Jul 14, 2021
@BarkingBad
Copy link
Contributor Author

Sorry @julienrf for the late response, I had some urgent things to do. I used Grammarly as you suggested for enhancing the quality of the docs.

@vincenzobaz may I ask you to look at the API changes and whether do you like them?

docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/settings.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
docs/docs/usage/scaladoc/staticSite.md Outdated Show resolved Hide resolved
Co-authored-by: Vinz <bazzucchi.vincenzo@gmail.com>
@BarkingBad BarkingBad force-pushed the scaladoc/update-docs branch from e674272 to 4987d0d Compare August 2, 2021 13:56
@BarkingBad BarkingBad force-pushed the scaladoc/update-docs branch from 4987d0d to edd52ba Compare August 2, 2021 14:09
@BarkingBad BarkingBad enabled auto-merge August 2, 2021 14:09
@BarkingBad BarkingBad disabled auto-merge August 2, 2021 16:58
@BarkingBad BarkingBad merged commit 1413dab into scala:master Aug 2, 2021
@Kordyjan Kordyjan added this to the 3.1.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple -d in scaladoc Standarize scaladoc parameters between Scala2 and Scala3
5 participants