Fix #13455: Also consider sealed classes closed sums #13483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings on master are incorrect: we know that no instance of SealedClass match the corresponding cases.
bishabosha
reviewed
Sep 8, 2021
This commit renames isClosedSum to isDecomposable, and moves that function and the decompose function to where they are used locally. The logic in question only makes sense at the precise point where it's used (see the added comment), so having those two functions defined locally helps to avoid confusion.
bishabosha
approved these changes
Sep 23, 2021
dwijnand
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
A small typo (iiuc) but looks good to me now, thanks for the attention, @OlivierBlanvillain!
Co-authored-by: Dale Wijnand <dale.wijnand@gmail.com>
|
Even better. 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.