repl: Handle user-defined res definitions #13600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Sep 23, 2021
dwijnand
force-pushed
the
repl-res-usage
branch
from
b047af7 to
f1a0d62
Compare
smarter
reviewed
Sep 23, 2021
dwijnand
force-pushed
the
repl-res-usage
branch
from
2b96e8e to
e3ab587
Compare
Member
|
@dwijnand looks like the pattern handling only works because we special-cased tuples: scala> val Some((res0, res1)) = Option((1, "foo"))
val res0: Int = 1
val res1: String = foo
scala> res0
-- [E045] Cyclic Error: --------------------------------------------------------
1 |res0
|^
|Recursive value res0 needs type
longer explanation available when compiling with `-explain`
1 error found |
Co-authored-by: Seth Tisue <seth@tisue.net>
dwijnand
force-pushed
the
repl-res-usage
branch
from
e3ab587 to
631fef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.