CI: test JDK 17, not 16 anymore #13629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
griggt
suggested changes
Sep 29, 2021
Comment on lines
+49
to
+50
| - name: Set JDK 17 as default | ||
| run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
Merely updating the path here is not sufficient to use JDK 17, since the custom Docker image used by the self-hosted CI runners only contains JDK 16 and JDK 8 (the default) at the moment.
It can be seen in the logs that JDK 8 is actually what was used for this PR run:
https://github.com/lampepfl/dotty/pull/13629/checks?check_run_id=3739562544#step:9:7
Run ./project/scripts/sbt ";scala3-bootstrapped/compile; scala3-bootstrapped/test;sjsSandbox/run;sjsSandbox/test;sjsJUnitTests/test;sjsCompilerTests/test ;sbt-test/scripted scala2-compat/* ;configureIDE ;stdlib-bootstrapped/test:run ;stdlib-bootstrapped-tasty-tests/test; scala3-compiler-bootstrapped/scala3CompilerCoursierTest:test"
[info] welcome to sbt 1.5.5 (Private Build Java 1.8.0_282)
The repo for the CI Docker image is https://github.com/lampepfl/dotty-ci
|
okay, I'll just close this then and hope someone else volunteers :-) |
|
The biggest holdup here is that someone with the proper credentials (e.g. Guillaume) would need to publish the new Docker image once it's updated in the dotty-ci repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.