Generalize main annotations #13727
Generalize main annotations #13727
Commits on Feb 6, 2022
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Generate class instead of object, instanciate main
- This allows for top-level main methods without name conflict with the companion object - Instead of extending main, instanciate a new main and call command on it - Will need to instanciate the @ class instead of @main (allowing easy overriding of methods) - Will need to check if not extending main is an issue
-
-
-
-
-
-
Add support for default values
main-annotation* tests now all pass again This is quite messy, it should most probably be cleaned or done in a cleaner way
-
-
-
The "This should not be printed!" lines are, in fact, printed in IDEs
-
-
-
-
-
-
Factorize getter code, check duplicate named param
- Extract argGetter and argGetterDefault into a helper method - When using multiple times the same arg by name, display an error
-
-
-
-
-
-
-
Rework of Arguments, change usage format
- Remove "case" keywork for Argument subclasses to avoid unapply pattern matching (future compatibility) - Change output of usage function to be more expressive
-
-
-
Make defaultValue by-name param
Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
-
Remove redundant val in ExitCode
Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
-
-
-
-
-
-
Fix issue where map is not member of Array[String | Null] | Null
- This was caused by changes in issue scala#13729
-
-
-
-
- Now that main is final, the code can be factorized
-
-
-
-
-
-
-
-
-
-
Pass doc to command; main parameter for line length
- Instead of passing arg docs to the args, pass the whole docstring to the command function and parse it on run - Add parameter in main to control max line width when printing
-
-
-
-
Remove ExitCode and result printing in main
- After discussing with LAMP members, I was instructed to not print the result of a main method
-
-
-
-
Factorize annotation instanciation code
- Tweak code for default values, add support for varargs - Add related tests
-
Pass object to argGetter instead of multiple params
- Instead of adding to the list of elements when we add functionalities to the getter functions, we now pass an object containing the values. That way, adding an argument is a matter of expanding the class ParameterInfos and adding a few lines in MainProxies
-
-
-
Add main.Arg annotation for argument-related parameters
- Add annotation for main method arguments - Add support for alternative names and short names
-
-
-
-
-
-
-
Use default values' symbols instead of trees
- This avoids having to somehow retype the value
-
Change structure of ParameterInfos
- Based on suggestion by Nicolas Stucki, here: https://gist.github.com/nicolasstucki/84ebcd5c2cfc9aa14abba96ae1a0e996 - Add ability to pass multiple ParameterAnnotations
-
-
-
Split Arg into ShortName and Name
- Allow for multiple parameter annotations - Rework the code of main to reflect changes and simplify treatment - Change output of help and usage to accomodate for multiple names
-
-
Fix issue with explicit type for parameters
- Before this fix, trying to remove the [Int] from the option resulted in: cannot infer type; expected type <?> is not fully defined To avoid this, we simply wrap the pre-typed arguments in TypedSplices
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Pass ParameterInfos in command instead of getters
- Pass ParameterInfos for parameters in the command method instead of the getter functions. This way, we know about all of them beforehand, and parsing can be done more efficiently.
-
-
Rework of main.Name and main.ShortName
- Merge Name and ShortName into Alias - Make Alias take a variable number of arguments - Distinguish between long and short names by string length
-
-
- --help and -h display usage and help - if an argument or an alias is the same as either help or h, disable help printing for that argument
-
