Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaladoc: Fix double implicit modifier #13909

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Scaladoc: Fix double implicit modifier #13909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5758a2b
Fix double implicit modifier
pikinier20 Nov 8, 2021
d8581de
Add test for implicit class
pikinier20 Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scaladoc-testcases/src/tests/classModifiers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ sealed case class D(c: String)
final case class E(c: String)

open class F

implicit class Foo(i: Int)
2 changes: 1 addition & 1 deletion scaladoc/src/dotty/tools/scaladoc/tasty/SymOps.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ object SymOps:
Flags.Case -> Modifier.Case,
).collect {
case (flag, mod) if sym.flags.is(flag) => mod
} ++ Seq(Modifier.Implicit).filter(_ => sym.isImplicitClass)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is isImplicitClass used anywhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in InkuireSupport :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, can that be rewritten as well now?

}

def isHiddenByVisibility(using dctx: DocContext): Boolean =
import VisibilityScope._
Expand Down