Fixes and improvements to trace logging #13984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The String.valueOf is because I somehow ended up with a null. Then I found some docs in the history of trace, as well as a mistake in a commit revert: using the non-StoreReporter logctx! I also added a "log" variant to "force", which is also default enabled but doesn't force the output to the standard out, meaning I can bootstrap the compiler without it taking forever to output all the trace output it generates while bootstrapping the compiler, bottlenecking on console IO)... Also, remove some dead code in Definitions.
nicolasstucki
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The String.valueOf is because I somehow ended up with a null.
Then I found some docs in the history of trace, as well as a mistake in
a commit revert: using the non-StoreReporter logctx!
I also added a "log" variant to "force", which is also default enabled
but doesn't force the output to the standard out, meaning I can
bootstrap the compiler without it taking forever to output all the trace
output it generates while bootstrapping the compiler, bottlenecking on
console IO)...
Also, remove some dead code in Definitions.