Skip to content

Fix reachability of unapplySeq of non-List sequences #14112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix reachability of unapplySeq of non-List sequences #14112

merged 1 commit into from
Dec 15, 2021

Conversation

@dwijnand
Copy link
Member

No description provided.

@dwijnand dwijnand linked an issue Dec 14, 2021 that may be closed by this pull request
Case Seq() is declared unreachable when matching a Vector #13931
Closed
@dwijnand dwijnand requested a review from liufengyun December 15, 2021 08:09
liufengyun
liufengyun approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@dwijnand dwijnand merged commit 5ed0586 into scala:master Dec 15, 2021
@dwijnand dwijnand deleted the reachabarity branch December 15, 2021 08:40
@Kordyjan Kordyjan added this to the 3.1.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels

None yet

Projects

None yet

Milestone

3.1.2

Development

Successfully merging this pull request may close these issues.

Case Seq() is declared unreachable when matching a Vector

3 participants

@dwijnand @liufengyun @Kordyjan