Dealias less in OrderingConstraint.replace and AvoidMap #14232
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just opened to run the CI but I didn't find time to check the failures yet |
joroKr21
force-pushed
the
dealias-less
branch
from
c126902 to
105e083
Compare
Basically if the transformation doesn't apply to the dealias type, then return the original type instead of the dealiased one. In general it's reduce dealiasing to a minimum when typing, because it can affect type unification as shown in the tests. Unfortunately this doesn't handle the case of a singleton type alias, because `widenSingletons` also dealiases and the same fix doesn't work.
joroKr21
force-pushed
the
dealias-less
branch
from
105e083 to
e38bdbc
Compare
|
Hey @joroKr21, just wanted to check in. Do you plan on returning back to this? |
|
Maybe. But for now I will close it because I have no time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically if the transformation doesn't apply to the dealias type,
then return the original type instead of the dealiased one.
In general it's reduce dealiasing to a minimum when typing,
because it can affect type unification as shown in the tests.
Unfortunately this doesn't handle the case of a singleton type alias,
because
widenSingletonsalso dealiases and the same fix doesn't work.