Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows CI; conditionally enable forward compat community build in PRs #14301

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fix windows CI; conditionally enable forward compat community build in PRs #14301

merged 1 commit into from
Jan 25, 2022

Conversation

prolativ
Copy link
Contributor

@prolativ prolativ commented Jan 20, 2022 •
edited
Loading

Fixes #14300
[test_windows_full]

@prolativ prolativ mentioned this pull request Jan 20, 2022
Merged
@dwijnand dwijnand linked an issue Jan 20, 2022 that may be closed by this pull request
Nightly Dotty workflow of 2022-01-20 failed #14300
Closed
@bishabosha
Copy link
Member

bishabosha commented Jan 20, 2022 •
edited
Loading

seems like that the path is well formed, but there is no actual scalac program there maybe?

Cannot run program "C:\Windows\ServiceProfiles\NetworkService\.cache\dotty\test\compilers\scala3-3.0.2\bin\scalac": CreateProcess error=193, %1 is not a valid Win32 application

@prolativ prolativ force-pushed the fix-windows-ci-for-forward-compat branch from d53ff1e to ae63b97 Compare January 20, 2022 11:00
@prolativ
Copy link
Contributor Author

prolativ commented Jan 20, 2022 •
edited
Loading

I guess it needs to be scalac.bat on Windows. Let's see if this works now

@bishabosha
Copy link
Member

now the tests are running, but it seems that the Test class is not being found by the test runner

@prolativ
Copy link
Contributor Author

When I try to debug it on a different windows machine there seem to be some strange problems with permissions to the generated classfiles

@prolativ prolativ force-pushed the fix-windows-ci-for-forward-compat branch 2 times, most recently from 497322c to 12b686c Compare January 24, 2022 13:00
@prolativ prolativ mentioned this pull request Jan 25, 2022
Closed
@nicolasstucki nicolasstucki linked an issue Jan 25, 2022 that may be closed by this pull request
Nightly Dotty workflow of 2022-01-25 failed #14341
Closed
@prolativ prolativ force-pushed the fix-windows-ci-for-forward-compat branch from 12b686c to dba1efe Compare January 25, 2022 15:30
@prolativ prolativ force-pushed the fix-windows-ci-for-forward-compat branch from dba1efe to 2de9cb2 Compare January 25, 2022 16:13
@prolativ prolativ removed the stat:wip label Jan 25, 2022
@bishabosha bishabosha merged commit 4d93f23 into scala:master Jan 25, 2022
@bishabosha bishabosha deleted the fix-windows-ci-for-forward-compat branch January 25, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

@dwijnand dwijnand dwijnand approved these changes

Assignees

@prolativ prolativ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2022-01-25 failed Nightly Dotty workflow of 2022-01-20 failed
3 participants
@prolativ @bishabosha @dwijnand