Drop all usage of sbt-dotty in community build
#14395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griggt
force-pushed
the
wip/cb-drop-sbt-dotty
branch
from
bb14522
to
0cf7c79
Compare
griggt
changed the title
sbt-dotty in community buildsbt-dotty in community build
This was referenced Feb 3, 2022
armanbilge
reviewed
Feb 3, 2022
|
Two of the Cats Effect tests picked up by the resync with upstream are failing since #14295 They have been disabled for now in dotty-staging/cats-effect@2510979 fyi @armanbilge |
|
@griggt fwiw, I think those tests are picking up an actual regression in the compiler. More discussion on the linked Cats Effect issue, but it appears at least in preliminary analysis that the compiler now generates additional redundant wrapping functions around thunks. CE is sensitive to this because of how it detects call sites for tracing purposes, which is why it fails functional tests, but it should also show up in microbenchmarks and other performance metrics. |
griggt
force-pushed
the
wip/cb-drop-sbt-dotty
branch
from
1d62ff0
to
e964de5
Compare
|
@djspiewak @armanbilge I see there has been additional discussion re: thunks on the linked ticket and Discord. If ultimately you feel there is a compiler regression that needs attention, please do open an issue. Thanks. |
griggt
force-pushed
the
wip/cb-drop-sbt-dotty
branch
from
e964de5
to
47a5b1d
Compare
This is the file which tracks projects published during the community build run, which are injected as dependency overrides into subsequently built projects. It can be useful to inspect this file when debugging.
The sbt-dotty plugin was deprecated with the release of sbt 1.5.0, and removed from the dotty build in b477c42 However it was still being injected into the community build, as many projects therein had not been updated to a recent sbt, or were using a (possibly outdated) version of sbt-dotty either directly or indirectly via some other plugin. This commit discontinues that practice, since sbt 1.6.x no longer plays nice with sbt-dotty (see the linked ticket scala#14391). Many of the community build projects are already updated upstream to use sbt 1.5.x or 1.6.x without sbt-dotty; those are updated to their upstream versions in this PR as appropriate. A handful of community build projects are either unmaintained or do not offer Scala 3 support upstream, or their inclusion in the community build was part of some special effort. Those projects, listed below, have had their dotty-staging forks updated to use sbt 1.6.2 and drop sbt-dotty. - betterfiles - effpi - fastparse - intent - scalap
The previous attempt at excluding the flaky tests, adapted from the Scala 2 community build, was not fully working here, most likely because of how those test sources are generated in the dotty version of the ScalaTest build. The fix in this commit has been verified by running the community build with the sbt logging level set to info and inspecting the output.
griggt
force-pushed
the
wip/cb-drop-sbt-dotty
branch
from
47a5b1d
to
ba71f7c
Compare
anatoliykmetyuk
approved these changes
Mar 8, 2022
|
Great to see this landing! Thanks Tom & everyone who helped 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sbt-dottyplugin was deprecated with the release of sbt 1.5.0, and removed from the dotty build in b477c42However it was still being injected into the community build, as many projects therein had not been updated to a recent sbt, or were using a (possibly outdated) version of
sbt-dottyeither directly or indirectly via some other plugin.This commit discontinues that practice, since sbt 1.6.x no longer plays nice with
sbt-dotty(see the linked ticket #14391).Many of the community build projects are already updated upstream to use sbt 1.5.x or 1.6.x without
sbt-dotty; those are updated to their upstream versions in this PR as appropriate.A handful of community build projects are either unmaintained or do not offer Scala 3 support upstream, or their inclusion in the community build was part of some special effort. Those projects, listed below, have had their
dotty-stagingforks updated to use sbt 1.6.2 and dropsbt-dotty.This PR also:
algebraas a separate project since it is now incorporated intocats[test_forward_compat]
Fixes #14391