Skip to content

Hande clashes between same-named exports #14967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2022
Merged

Hande clashes between same-named exports #14967

merged 5 commits into from
Apr 22, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 18, 2022 •
edited
Loading

Fixes #14966

Two parts

  1. Better error message for "clashes after erasure message". We now print the original types of the clashing definitions as well as their common erased type.
  2. In most cases heal the clash between two export forwarders by picking the one which is better according to overloading resolution.

odersky added 2 commits April 18, 2022 21:45
@odersky
Print double definitions signatures at Typer
857ed96 
Fixes scala#14966
@odersky
Fix check file
3c6425b 
Is this a stability problem? It seems the CI visits Seq definitions in different order than local.
dwijnand
dwijnand reviewed Apr 19, 2022
View reviewed changes
@odersky
Avoid export clashes
8d1c435 
Avoid export clashes in most cases by picking the alternative which
would be preferred by overloading resolution. If none is, issue a
more intelligible error message than before.
@odersky odersky changed the title Print double definitions signatures at Typer Hande clashes between same-named exports Apr 20, 2022
odersky added 2 commits April 20, 2022 19:31
@odersky
Print erased type in double definition message
fed2764 
Print erased type if the message says "have the same type after erasure"
@odersky
Pick correct forwarder to avoid clashes
806386e 
We should pick the one which is better, but we mistakenly chose the
worst one instead, since I misinterpreted the ordering.
dwijnand
dwijnand approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@dwijnand dwijnand merged commit c7c3c14 into scala:main Apr 22, 2022
@dwijnand dwijnand deleted the fix-14966 branch April 22, 2022 10:23
@bjornregnell
Copy link
Contributor

This is awesome!

@griggt griggt mentioned this pull request Jun 22, 2022
Closed
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Strange error when exporting overloaded stuff from the collection library
4 participants
@odersky @bjornregnell @dwijnand @Kordyjan