Skip to content

Fix signatureHelp to show enclosing apply instead of closest one. #15119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2022

Conversation

rochala
Copy link
Contributor

@rochala rochala commented May 5, 2022

Fixes #14661

Previously signatureHelp allowed us to trigger doTh${m1}ing(List(1,2,3)) which is not wanted.
The problem was caused by incorrect path pass by not checking if closest path
contains given position in whole tree instead of its parameters. Now it's kinda fixed but will need
changes in tools which used this function to properly show signatureHelp.

It will require changes in tooling which uses helpSignatures to properly drop arguments.

@rochala rochala requested a review from tgodzik May 5, 2022 16:27
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rochala rochala merged commit 9817323 into scala:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignatureHelp gives apply of the current symbol instead of enclosing apply
2 participants