Skip to content

Show a match type trace for "not a class type" errors #15218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2022
Merged

Show a match type trace for "not a class type" errors #15218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c1328d
Show a match type trace for "not a class type" errors
odersky May 18, 2022
213b4dd
Update sjs check files
odersky May 18, 2022
bdcbff9
Update error number in check files
odersky May 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/src/dotty/tools/dotc/reporting/ErrorMessageID.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ enum ErrorMessageID(val isActive: Boolean = true) extends java.lang.Enum[ErrorMe
case LossyWideningConstantConversionID // errorNumber: 167
case ImplicitSearchTooLargeID // errorNumber: 168
case TargetNameOnTopLevelClassID // errorNumber: 169

case NotClassTypeID // errorNumber 170

def errorNumber = ordinal - 1

object ErrorMessageID:
Expand Down
5 changes: 5 additions & 0 deletions compiler/src/dotty/tools/dotc/reporting/messages.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2521,3 +2521,8 @@ import transform.SymUtils._
| $annot $symbol { ... }
|
|${hl("export")} Wrapper.${symbol.name} ${hl("// optional")}"""

class NotClassType(tp: Type)(using Context)
extends TypeMsg(NotClassTypeID), ShowMatchTrace(tp):
def msg = ex"$tp is not a class type"
def explain = ""
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Checking.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ trait Checking {
if (stablePrefixReq && ctx.phase <= refchecksPhase) checkStable(tref.prefix, pos, "class prefix")
tp
case _ =>
report.error(ex"$tp is not a class type", pos)
report.error(NotClassType(tp), pos)
defn.ObjectType
}

Expand Down
16 changes: 8 additions & 8 deletions tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.check
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,39 @@
13 | val a = js.constructorOf[NativeJSTrait] // error
| ^^^^^^^^^^^^^
| non-trait class type required but NativeJSTrait found
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:14:27 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:14:27 -----------------------------
14 | val b = js.constructorOf[NativeJSObject.type] // error
| ^^^^^^^^^^^^^^^^^^^
| NativeJSObject.type is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:16:27 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:16:27 -----------------------------
16 | val c = js.constructorOf[NativeJSClass with NativeJSTrait] // error
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| NativeJSClass & NativeJSTrait is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:17:27 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:17:27 -----------------------------
17 | val d = js.constructorOf[NativeJSClass { def bar: Int }] // error
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| NativeJSClass{bar: Int} is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:19:27 -----------------------------------------
19 | val e = js.constructorOf[JSTrait] // error
| ^^^^^^^
| non-trait class type required but JSTrait found
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:20:27 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:20:27 -----------------------------
20 | val f = js.constructorOf[JSObject.type] // error
| ^^^^^^^^^^^^^
| JSObject.type is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:22:27 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:22:27 -----------------------------
22 | val g = js.constructorOf[JSClass with JSTrait] // error
| ^^^^^^^^^^^^^^^^^^^^
| JSClass & JSTrait is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:23:27 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:23:27 -----------------------------
23 | val h = js.constructorOf[JSClass { def bar: Int }] // error
| ^^^^^^^^^^^^^^^^^^^^^^^^
| JSClass{bar: Int} is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:25:42 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:25:42 -----------------------------
25 | def foo[A <: js.Any] = js.constructorOf[A] // error
| ^
| A is not a class type
-- Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:26:66 -----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructorof-error-in-prepjsinterop.scala:26:66 -----------------------------
26 | def bar[A <: js.Any: scala.reflect.ClassTag] = js.constructorOf[A] // error
| ^
| A is not a class type
16 changes: 8 additions & 8 deletions tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.check
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,39 @@
13 | val a = js.constructorTag[NativeJSTrait] // error
| ^
| non-trait class type required but NativeJSTrait found
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:14:48 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:14:48 ----------------------------
14 | val b = js.constructorTag[NativeJSObject.type] // error
| ^
| NativeJSObject.type is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:16:61 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:16:61 ----------------------------
16 | val c = js.constructorTag[NativeJSClass with NativeJSTrait] // error
| ^
| (NativeJSClass & NativeJSTrait) is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:17:59 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:17:59 ----------------------------
17 | val d = js.constructorTag[NativeJSClass { def bar: Int }] // error
| ^
| NativeJSClass{bar: Int} is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:19:36 ----------------------------------------
19 | val e = js.constructorTag[JSTrait] // error
| ^
| non-trait class type required but JSTrait found
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:20:42 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:20:42 ----------------------------
20 | val f = js.constructorTag[JSObject.type] // error
| ^
| JSObject.type is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:22:49 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:22:49 ----------------------------
22 | val g = js.constructorTag[JSClass with JSTrait] // error
| ^
| (JSClass & JSTrait) is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:23:53 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:23:53 ----------------------------
23 | val h = js.constructorTag[JSClass { def bar: Int }] // error
| ^
| JSClass{bar: Int} is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:25:45 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:25:45 ----------------------------
25 | def foo[A <: js.Any] = js.constructorTag[A] // error
| ^
| A is not a class type
-- Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:26:69 ----------------------------------------
-- [E170] Type Error: tests/neg-scalajs/jsconstructortag-error-in-prepjsinterop.scala:26:69 ----------------------------
26 | def bar[A <: js.Any: scala.reflect.ClassTag] = js.constructorTag[A] // error
| ^
| A is not a class type
6 changes: 3 additions & 3 deletions tests/neg/classOf.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
-- Error: tests/neg/classOf.scala:6:22 ---------------------------------------------------------------------------------
-- [E170] Type Error: tests/neg/classOf.scala:6:22 ---------------------------------------------------------------------
6 | def f1[T] = classOf[T] // error
| ^
| T is not a class type
-- Error: tests/neg/classOf.scala:7:32 ---------------------------------------------------------------------------------
-- [E170] Type Error: tests/neg/classOf.scala:7:32 ---------------------------------------------------------------------
7 | def f2[T <: String] = classOf[T] // error
| ^
| T is not a class type
|
| where: T is a type in method f2 with bounds <: String
-- Error: tests/neg/classOf.scala:9:18 ---------------------------------------------------------------------------------
-- [E170] Type Error: tests/neg/classOf.scala:9:18 ---------------------------------------------------------------------
9 | val y = classOf[C { type I = String }] // error
| ^^^^^^^^^^^^^^^^^^^^^
| Test.C{I = String} is not a class type
4 changes: 2 additions & 2 deletions tests/neg/i13808.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
-- Error: tests/neg/i13808.scala:13:37 ---------------------------------------------------------------------------------
-- [E170] Type Error: tests/neg/i13808.scala:13:37 ---------------------------------------------------------------------
13 |case class Boom[A](value: A) derives OpaqueType, Foo // error // error
| ^^^^^^^^^^
| OpaqueTypes.OpaqueType is not a class type
-- Error: tests/neg/i13808.scala:13:49 ---------------------------------------------------------------------------------
-- [E170] Type Error: tests/neg/i13808.scala:13:49 ---------------------------------------------------------------------
13 |case class Boom[A](value: A) derives OpaqueType, Foo // error // error
| ^^^
| FooModule.Foo is not a class type
11 changes: 11 additions & 0 deletions tests/neg/i15155.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
-- [E170] Type Error: tests/neg/i15155.scala:10:33 ---------------------------------------------------------------------
10 | val EnumerationClass = classOf[EnumValue[E]] // error
| ^^^^^^^^^^^^
| EnumValue[E] is not a class type
|
| Note: a match type could not be fully reduced:
|
| trying to reduce EnumValue[E]
| failed since selector E
| does not match case Aux[a] => a
| and cannot be shown to be disjoint from it either.
11 changes: 11 additions & 0 deletions tests/neg/i15155.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import scala.reflect.ClassTag
// https://github.com/json4s/json4s/blob/355d8751391773e0d79d04402a4f9fb7bfc684ec/ext/src/main/scala-3/org/json4s/ext/package.scala#L4-L8
type Aux[A] = { type Value = A }
type EnumValue[A <: Enumeration] = A match {
case Aux[a] => a
}

// https://github.com/json4s/json4s/blob/355d8751391773e0d79d04402a4f9fb7bfc684ec/ext/src/main/scala/org/json4s/ext/EnumSerializer.scala#L25-L26
class EnumSerializer[E <: Enumeration: ClassTag](enumeration: E) {
val EnumerationClass = classOf[EnumValue[E]] // error
}