Skip to content

Fix relativizing paths in coverage serializer #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2022
Merged

Fix relativizing paths in coverage serializer #15240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/src/dotty/tools/dotc/coverage/Serializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ object Serializer:
def serialize(coverage: Coverage, writer: Writer, sourceRoot: Path): Unit =

def getRelativePath(filePath: Path): String =
val relPath = sourceRoot.relativize(filePath)
// We need to normalize the path here because the relativizing paths containing '.' or '..' differs between Java versions
// https://bugs.openjdk.java.net/browse/JDK-8066943
val relPath = sourceRoot.normalize.relativize(filePath)
relPath.toString

def writeHeader(writer: Writer): Unit =
Expand Down