Skip to content

Remove ErrorMessageID.LazyErrorId and improve doc #15271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2022
Merged

Remove ErrorMessageID.LazyErrorId and improve doc #15271

merged 3 commits into from
May 26, 2022

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki mentioned this pull request May 23, 2022
Merged
@nicolasstucki nicolasstucki changed the title Remove ErrorMessageID.LazyErrorId Remove ErrorMessageID.LazyErrorId and improve doc May 23, 2022
@nicolasstucki nicolasstucki self-assigned this May 23, 2022
@nicolasstucki nicolasstucki marked this pull request as ready for review May 23, 2022 16:19
ckipp01
ckipp01 approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

After this is merged in I can go ahead and add in the explicit id that was outlined here if we are all in agreement.

@nicolasstucki
Copy link
Contributor Author

After this is merged in I can go ahead and add in the explicit id that was outlined #14965 (comment) if we are all in agreement.

I'll do that later to avoid conflicts with a couple of open PR

@nicolasstucki nicolasstucki requested a review from odersky May 24, 2022 10:57
@nicolasstucki nicolasstucki added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label May 24, 2022
@odersky odersky merged commit 199c516 into scala:main May 26, 2022
@odersky odersky deleted the remove-LazyErrorId branch May 26, 2022 07:59
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees

@odersky odersky

Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasstucki @odersky @ckipp01 @Kordyjan