Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: try to fix initialization warnings in NameKinds #15462

Closed
wants to merge 10 commits into from
Closed

wip: try to fix initialization warnings in NameKinds #15462

wants to merge 10 commits into from

Commits on Jun 16, 2022

  1. Fix scala#15363: Improve error messages of leaked non-hot values

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    ca6d644 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    d719a40 View commit details
    Browse the repository at this point in the history

  3. Refine the logic for accessing secondary ctor params

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7b496de View commit details
    Browse the repository at this point in the history

  4. Remove env for Fun 

    We do not need it any more because we store secondary constructor parameter values on `this`.
    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a77479a View commit details
    Browse the repository at this point in the history

  5. Refactor code

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    c6b3e79 View commit details
    Browse the repository at this point in the history

  6. Better division of Error.show and Error.issue

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    162687f View commit details
    Browse the repository at this point in the history

  7. Show which argument is non-hot

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    c4c8c7f View commit details
    Browse the repository at this point in the history

  8. Make internal error more explicit in the message

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    e63b794 View commit details
    Browse the repository at this point in the history

  9. Add minimized test

    @liufengyun @olhotak
    liufengyun authored and olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0490d4b View commit details
    Browse the repository at this point in the history

  10. try to eliminate initialization warnings in NameKinds

    @olhotak
    olhotak committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0127b13 View commit details
    Browse the repository at this point in the history