Skip to content

Try promotion while widening arguments #15467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2022
Merged

Try promotion while widening arguments #15467

merged 3 commits into from
Jun 17, 2022

Conversation

@liufengyun
Copy link
Contributor

Try promotion while widening arguments

@liufengyun liufengyun requested a review from olhotak June 16, 2022 21:06
olhotak
olhotak approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also fixes 3 initialization warnings when compiling the compiler.

@liufengyun liufengyun mentioned this pull request Jun 17, 2022
Closed
@liufengyun liufengyun merged commit f58c158 into scala:main Jun 17, 2022
@liufengyun liufengyun deleted the fix-scala-js-init branch June 17, 2022 17:18
This was referenced Jun 22, 2022
Closed
Merged
@liufengyun liufengyun mentioned this pull request Aug 8, 2022
Open
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olhotak olhotak olhotak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@liufengyun @olhotak @Kordyjan