Don't unsoundly maximise types to Any/Nothing #15509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
gadt/unsound-cast
branch
from
b6252b1 to
5b34415
Compare
Also fix the span of the new pattern bound symbol, which was failing pickling tests.
dwijnand
force-pushed
the
gadt/unsound-cast
branch
from
5b34415 to
d055a8d
Compare
dwijnand
force-pushed
the
gadt/unsound-cast
branch
from
0cb299b to
b7b2689
Compare
dwijnand
commented
Jun 23, 2022
| @@ -0,0 +1,13 @@ | |||
| sealed trait Tree[+A] | |||
| final case class Leaf[+B](v: B) extends Tree[B] | |||
| final case class Node[+C](xs: List[C]) extends Tree[List[C]] | |||
There was a problem hiding this comment.
Change this to
Suggested change
| final case class Node[+C](xs: List[C]) extends Tree[List[C]] | |
| final case class Node[+C <: AnyRef](xs: List[C]) extends Tree[List[C]] |
and use Integer instead of Int, and it's goes back to breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the span of the new pattern bound symbol,
which was failing pickling tests.
[test_non_bootstrapped]