REPL: make truncation by characters configurable #16167
Conversation
via `-Vrepl-max-print-characters` The default character limit changes: instead of cutting at 1000 chars, it is now 50k. The previous default was rather low, and only made sense because it was also (and confusingly) used for the `MaxElements` truncation. This compliments scala#16011 and is based on our discussion there, specifically scala#16011 (review)
|
It would be nice to have a test showing the interaction between truncation on elements and truncation on characters limit. Especially, might the latter setting truncate the truncation message from the former, something like |
|
That's a good idea, thanks, will do! |
mpollmeier
force-pushed
the
repl/configurable-truncation-character-limit
branch
2 times, most recently
from
2e507f8 to
1475a6f
Compare
|
@mpollmeier are you sure you committed all your changes? I can't see any difference |
|
I didn't do anything yet, aside from rebasing the branch, which confused the github PR web view, so I reverted to the old version before the rebase. Will let you know when it's ready to re-review. |
|
It's ready to re-review now. |
via
-Vrepl-max-print-charactersThe default character limit changes: instead of cutting at 1000 chars, it is now 50k. The previous default was rather low, and only made sense because it was also (and confusingly) used for the
MaxElementstruncation.This compliments #16011 and is based on our discussion there, specifically #16011 (review)
I dropped the
i11377test because it didn't seem to add any value over the new test, while being quite confusing to read. I can add it back though...