Skip to content

Refactor Tree parameterization, with tweaks #16301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2022
Merged

Refactor Tree parameterization, with tweaks #16301

merged 2 commits into from
Nov 8, 2022

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Nov 8, 2022

  • Refactor Tree parameterization
  • Some trailing Tree refactor changes

odersky and others added 2 commits November 8, 2022 12:17
@odersky
Refactor Tree parameterization
476bf86 
Refactor `Tree` parameterization to make use of -Yexplicit-nulls.

We now have:

```scala
   type Untyped = Type | Null
   abstract class Tree[+T <: Untyped]
   object untpd:
     type Tree = Tree[Untyped]
   object tpe:
     type Tree = Tree[Type]
```
@dwijnand
Some trailing Tree refactor changes
1685473
@dwijnand dwijnand marked this pull request as ready for review November 8, 2022 14:14
@dwijnand dwijnand requested a review from odersky November 8, 2022 14:14
odersky
odersky approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more polished now!

@odersky odersky linked an issue Nov 8, 2022 that may be closed by this pull request
Refactor tree type parameters #16298
Closed
@odersky odersky merged commit 1e3739c into scala:main Nov 8, 2022
@dwijnand dwijnand deleted the Trees-Untyped-cov branch November 8, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tree type parameters
2 participants
@dwijnand @odersky