Skip to content

Update scalatest in community build #16428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 28, 2022

[skip test]
[skip test_windows_fast]
[skip test_sbt]
[skip mima]
[skip docs]
[skip community_build_b]
[skip community_build_c]

Some tests were disabled due to failures involving intercept of exception. These could be regression in the compiler or a bug in a scalatest macro.

@nicolasstucki nicolasstucki self-assigned this Nov 28, 2022
@nicolasstucki nicolasstucki force-pushed the update-scalatest branch 2 times, most recently from ca7c179 to 537582f Compare November 28, 2022 13:04
@nicolasstucki nicolasstucki changed the title Update scalatest in community build Update scalatest in community build Nov 28, 2022
@nicolasstucki nicolasstucki force-pushed the update-scalatest branch 7 times, most recently from 81a1be9 to ac904eb Compare December 5, 2022 11:12
@nicolasstucki nicolasstucki force-pushed the update-scalatest branch 2 times, most recently from d42218b to ea9aeb3 Compare December 7, 2022 16:04
@nicolasstucki nicolasstucki marked this pull request as ready for review December 9, 2022 10:36
@nicolasstucki
Copy link
Contributor Author

@cheeseng could you check if this regression happens on the scalatest main branch using our latest nightly build? We should make sure that this is not something that will affect scalatest before we release 3.3.0.

@cheeseng
Copy link

cheeseng commented Dec 9, 2022

@nicolasstucki I'll give it a try and report back here.

@cheeseng
Copy link

cheeseng commented Dec 9, 2022

@nicolasstucki I tried to build scalatest's main branch using 3.3.0-RC1-bin-20221205-5cf8a58-NIGHTLY via jdk8, jdk11 and jdk17, seems to work fine. Did community build failed on jdk16?

@cheeseng
Copy link

cheeseng commented Dec 9, 2022

@nicolasstucki I just tested jdk16 and it works fine too, is 3.3.0-RC1-bin-20221205-5cf8a58-NIGHTLY the latest version that I should be testing with?

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Dec 14, 2022

@cheeseng there are a couple of tests that failed in our build (JDK 8 I believe). I wonder if I pulled the correct scalatest branch into dotty-staging/scalatest@39370e3...6be253c. Could you check if this history makes sense?

Otherwise it could be an issue with the patches we have done (scalatest/scalatest@main...dotty-staging:scalatest:patched3). Or it could be an issue with the custom project setting/setup we use for the community build.

@cheeseng
Copy link

@nicolasstucki I am sorry I missed the notification of your message, I am not sure why branch you pulled, fyi for current stable version 3.2.x we are building it from branch name 3.2.x-new, and the main branch is for our upcoming 3.3.0 release.

I did tried to build the mentioned 2 branches (3.2.x-new and main) with 3.3.0-RC1-bin-20221205-5cf8a58-NIGHTLY, both works.

Do let me know if there's anything I can help in the community build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants