Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more performance tweaks #16791

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Some more performance tweaks #16791

wants to merge 9 commits into from

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 31, 2023

No description provided.

@odersky
Inline Period#contains in denot
5f390be
@odersky
Allow to record call chains in Stats
0e1f874
@odersky
Streamline hkResult
abcbc05 
No dealias is needed here
@odersky
Avoid symbol -> denot roundTrip in SourceLanguage
0bef578
@odersky
Optimize widenIfUnstable
321181a
@odersky
Optimize asContextFunctionType
7ceea97 
It is called surprisingly often (~40 times per LOC), and is fairly complicated
so a bit of caching could be worthwhile.
@odersky
Copy link
Contributor Author

odersky commented Jan 31, 2023

Test performance please

@odersky
Copy link
Contributor Author

odersky commented Jan 31, 2023

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/16791/ to see the changes.

Benchmarks is based on merging with main (42f2764)

@odersky
Drop asContextFunctionType in Definitions
63ac075 
Also for related methods. Use the methods in Types instead.
@odersky
Copy link
Contributor Author

odersky commented Jan 31, 2023

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/16791/ to see the changes.

Benchmarks is based on merging with main (42f2764)

@odersky
Copy link
Contributor Author

odersky commented Jan 31, 2023

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/16791/ to see the changes.

Benchmarks is based on merging with main (42f2764)

@odersky
Copy link
Contributor Author

odersky commented Feb 1, 2023

test performance please

@dottybot
Copy link
Member

dottybot commented Feb 1, 2023

performance test scheduled: 1 job(s) in queue, 1 running.

@odersky
Copy link
Contributor Author

odersky commented Feb 1, 2023

test performance please

@dottybot
Copy link
Member

dottybot commented Feb 1, 2023

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Feb 1, 2023

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/16791/ to see the changes.

Benchmarks is based on merging with main (0b08074)

1 similar comment
@dottybot
Copy link
Member

dottybot commented Feb 1, 2023

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/16791/ to see the changes.

Benchmarks is based on merging with main (0b08074)

@radeusgd radeusgd mentioned this pull request Mar 22, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @dottybot