Fix reflect.LambdaType type test #16972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-16961
branch
from
a32af5e to
4386f3f
Compare
nicolasstucki
commented
Feb 21, 2023
|
|
||
| case ParamRef(m: MethodType, i) => tpe(m.paramNames(i)).l ++ plain(".type").l | ||
|
|
||
| case ParamRef(binder: LambdaType, i) => tpe(binder.paramNames(i)).l |
There was a problem hiding this comment.
case ParamRef(TypeLambda(names, _, _), i) was accidentally matching TypeLambda and PolyType here. Replaced with LambdaType that matches TypeLambda, PolyType, and MethodType.
smarter
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16961