scaladoc should take -Werror/-Xfatal-warnings into account

[mkurz]

Alternative to #17022

[som-snytt]

Scaladoc settings already uses AllScalaSettings. I must be missing something. That's what I intended on the other PR.

https://github.com/lampepfl/dotty/blob/main/scaladoc/src/dotty/tools/scaladoc/ScaladocSettings.scala#L6

[som-snytt]

The relevant filtering is at https://github.com/lampepfl/dotty/blame/main/scaladoc/src/dotty/tools/scaladoc/Scaladoc.scala#L123

where only common settings are retained.

I tried it out locally. I see the use case is that Scaladoc tool emits warnings.

$ ~/projects/dotty/bin/scaladoc -d /tmp/sandbox -Werror S.tasty
-- Error: s.scala:7:6 --------------------------------------------------------------------------------------------------
7 |class S {
  |      ^
  |      No DRI found for query: some

-Wconf could also be relocated to common. I'll try it out, too, albeit I put them after silentWarnings.

Incremental compilation breaks with this edit, alas.

[som-snytt]

This looks good and could even move Wconf.

[som-snytt]

Must rerun CI anyway, and add Wconf definitely.

Probably there is a command here to rerun CI.

[som-snytt]

scaladoc/build says

Problem parsing scaladoc/src/dotty/tools/scaladoc/tasty/ClassLikeSupport.scala:[0..29..29489], documentation may not be generated.
Problem parsing scaladoc/src/dotty/tools/scaladoc/tasty/InkuireSupport.scala:[0..29..16233], documentation may not be generated.
Problem parsing scaladoc/src/dotty/tools/scaladoc/tasty/PackageSupport.scala:[0..20..517], documentation may not be generated.
Error:  -- Error: scaladoc/src/dotty/tools/scaladoc/tasty/comments/wiki/Entities.scala:10:17 
Error:  10 |final case class Body(blocks: Seq[Block]) {
Error:     |                 ^
Error:     |       No DRI found for query: scala.tools.nsc.doc.model.comment.Summary
Error:  -- Error: docs/_docs/index.md --------------------------------------------------
Error:  /home/runner/work/dotty/dotty/./docs/_docs/index.md: Unable to resolve link 'docs/reference/index.html'
Error:  -- Error: docs/_docs/reference/overview.md -------------------------------------
Error:  /home/runner/work/dotty/dotty/./docs/_docs/reference/overview.md: Unable to resolve link 'new-types/intersection-types.md'
Error:  -- Error: docs/_docs/reference/overview.md -------------------------------------
Error:  /home/runner/work/dotty/dotty/./docs/_docs/reference/overview.md: Unable to resolve link 'new-types/union-types.md'
Error:  -- Error: docs/_docs/reference/overview.md -------------------------------------

I'll attempt to follow up. Possibly not this evening.

[dabrowski-adam]

This would be very helpful to work around #20028. In a project that I work on, we had to disable treating warnings as errors because No DRI found for query: Enum caused sbt publishLocal to fail.

[KacperFKorban]

@dabrowski-adam I think that there is a specific scaladoc setting for disabling these warnings - -no-link-warnings.