Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealias quoted types when staging #17059

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Dealias quoted types when staging #17059

merged 2 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Dealias quoted types when staging 

    This change improves the code generation of the contents of splices. In
the splicing phase, we have to find all types that are defined in the
quote but used in the splice. When there are type aliases, we can end up
with several `Type[T]` for the different aliases of `T`. By dealiasing
during the staging phase (just before splicing phase) we make sure that
the splicer phase will only generate one `Type[T]`.

By dealiasing we also optimize some situations where a type from outside
a quote is inserted in the quoted code and then used in one of its
splice through an alias. In this situation we can use the outer
`Type[T]` directly.
    @nicolasstucki
    nicolasstucki committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1053899 View commit details
    Browse the repository at this point in the history

  2. Avoid transforming the body in optimization case

    @nicolasstucki
    nicolasstucki committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d479de6 View commit details
    Browse the repository at this point in the history