Drop incorrect super accessor in trait subclass #17062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a trait extends a class and accesses a protected member (while in a different package), we would emitted a super accessor and call that instead. That breaks the semantics because if the protected member is overridden, that implementation won't be called, as the call is to the super method instead. In addition to that, the call to the super accessor was causing a false positive error as we don't allow super calls to bind to vals.
odersky
requested changes
Mar 13, 2023
odersky
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a trait extends a class and accesses a protected member (while in a
different package), we would emitted a super accessor and call that
instead. That breaks the semantics because if the protected member is
overridden, that implementation won't be called, as the call is to the
super method instead.
In addition to that, the call to the super accessor was causing a false
positive error as we don't allow super calls to bind to vals.