Optimize captured type in splice hole #17070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
optimize-captured-type-in-splice-hole
branch
2 times, most recently
from
3c21401
to
2ef2f58
Compare
If we have a quote that defined a type `T` and use it in the contents of the splice we want to pass a `Type[T]` to the hole. This improves a case where we had a `List[T]` and the hole could end up with a `Type[T]` and `Type[List[T]]`. We should only pass the `Type[T]`.
nicolasstucki
force-pushed
the
optimize-captured-type-in-splice-hole
branch
from
2ef2f58
to
eb0d817
Compare
natsukagami
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a quote that defined a type
Tand use it in the contents of the splice we want to pass aType[T]to the hole.This improves a case where we had a
List[T]and the hole could end up with aType[T]andType[List[T]]. We should only pass theType[T].