Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:better error msg for cyclic error for constructors #17114

Closed
wants to merge 0 commits into from
Closed

fix:better error msg for cyclic error for constructors #17114

wants to merge 0 commits into from

Conversation

doofin
Copy link

@doofin doofin commented Mar 15, 2023

This provides better error msg for #17076 , doesn't solve the cyclic error yet
image

@doofin

This comment was marked as resolved.

Sign in to view
@SethTisue
Copy link
Member

SethTisue commented Mar 18, 2023 •
edited
Loading

the CoursierScalaTests failure will probably go away if you rebase on top of the recently merged #17127

@doofin doofin closed this Mar 18, 2023
@doofin
Copy link
Author

doofin commented Mar 18, 2023

Sorry I just messed up with my branch , new PR goes to #17131 rebased with recent updates

@anatoliykmetyuk
Copy link
Contributor

the CoursierScalaTests failure will probably go away if you rebase on top of the recently merged #17127

That PR only adds better debugging info for the error. #17141 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doofin @SethTisue @anatoliykmetyuk