Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port scrollbar to language reference stable #17334

Merged
merged 3 commits into from
May 10, 2023
Merged

Port scrollbar to language reference stable #17334

merged 3 commits into from
May 10, 2023

Conversation

szymon-rd
Copy link
Contributor

No description provided.

ckipp01
ckipp01 requested changes May 9, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an extra commit in here? The coursier changes? Are you able to rebase to clean that up and then I think this should be good to go!

@szymon-rd
Copy link
Contributor Author

@ckipp01 This commit is backported on purpose, as the CI was failing on this PR and this commit fixes that.

ckipp01
ckipp01 approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckipp01 This commit is backported on purpose, as the CI was failing on this PR and this commit fixes that.

Ah gotcha gotcha. Cool, thanks! LGTM

@szymon-rd szymon-rd merged commit ea65ae0 into scala:language-reference-stable May 10, 2023
@bishabosha bishabosha mentioned this pull request May 11, 2023
Merged
bishabosha added a commit that referenced this pull request May 11, 2023
@bishabosha
Re port scroll bar (#17463)
c84fbac 
follows #17334 which was merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szymon-rd @ckipp01 @Dedelweiss @anatoliykmetyuk