Refactor: Path validation and SiderbarParserTest #18000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedelweiss
force-pushed
the
refactor-sidebar-parser
branch
3 times, most recently
from
f2571ae to
4d840c2
Compare
…st by erasing the title only The goal of this PR is to re-add the path validation of page in the sidebar and improve the testcase by erasing the first title, so it's easier to understand the problem in it.
Dedelweiss
force-pushed
the
refactor-sidebar-parser
branch
from
4d840c2 to
1a1a6da
Compare
Florian3k
approved these changes
Jun 21, 2023
Kordyjan
pushed a commit
that referenced
this pull request
Nov 23, 2023
The goal of this PR is to re-add the path validation of the page in a sidebar.yaml and improve the Testcase in the `SidebarParserTest` by erasing the first title, so it's easier to understand the problem in it. This PR is related to PRs: #17229 & #17959 [test_windows_full] Co-authored-by: Lucas Leblanc <lucas@Lucass-MBP.rtd.lunatech.com> [Cherry-picked cf50fe3]
Kordyjan
pushed a commit
that referenced
this pull request
Nov 29, 2023
The goal of this PR is to re-add the path validation of the page in a sidebar.yaml and improve the Testcase in the `SidebarParserTest` by erasing the first title, so it's easier to understand the problem in it. This PR is related to PRs: #17229 & #17959 [test_windows_full] Co-authored-by: Lucas Leblanc <lucas@Lucass-MBP.rtd.lunatech.com> [Cherry-picked cf50fe3]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to re-add the path validation of the page in a sidebar.yaml and improve the Testcase in the
SidebarParserTestby erasing the first title, so it's easier to understand the problem in it.This PR is related to PRs: #17229 & #17959
[test_windows_full]