Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding an accessible non-private reference #18139

Closed
wants to merge 1 commit into from
Closed

Fix finding an accessible non-private reference #18139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/src/dotty/tools/dotc/typer/Typer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
val pre = expr.tpe
val denot0 = pre.memberBasedOnFlags(name, required, excluded)
.accessibleFrom(pre)(using refctx)
.orElse(pre.memberBasedOnFlags(name, required, excluded | Private)
.accessibleFrom(pre)(using refctx))
// Pass refctx so that any errors are reported in the context of the
// reference instead of the context of the import scope
if denot0.exists then
Expand Down
9 changes: 9 additions & 0 deletions tests/pos/i18135.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
class Ace
class Bar(last: Ace) { implicit val now: Ace = last }
class Foo(now: Ace) extends Bar(now)
class Test {
def test(fst: Foo) = {
import fst._
now != null
}
}