Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for issue #17997 affecting the global object initialization checker #18141

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

olhotak
Copy link
Contributor

@olhotak olhotak commented Jul 4, 2023

Issue #17997 reported a minimized example that crashed the object instance initialization checker. That checker was fixed in #18069. However, a similar example also crashes the global object initialization checker. This PR adds a test that exhibits this crash in the global object initialization checker.

@olhotak olhotak requested a review from liufengyun July 4, 2023 19:51
@olhotak olhotak self-assigned this Jul 4, 2023
@liufengyun
Copy link
Contributor

Thank you @olhotak .

@olhotak
Copy link
Contributor Author

olhotak commented Jul 24, 2023

Thanks @EnzeXing . Please add a test in which the self type is an intersection type. Otherwise LGTM.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnzeXing
Copy link
Contributor

Thanks @EnzeXing . Please add a test in which the self type is an intersection type. Otherwise LGTM.

The test has been added

@olhotak olhotak merged commit ac69c66 into scala:main Jul 27, 2023
@olhotak olhotak deleted the add-test-super-init-global branch July 27, 2023 16:36
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants