Improve parameter type inference error messaging #18190
Merged
+37
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,14 +1,18 @@ | |||
| -- [E081] Type Error: tests/neg/i17183.scala:11:24 --------------------------------------------------------------------- | |||
| 11 |def test = Context(f = (_, _) => ???) // error // error | |||
| | ^ | |||
| | Missing parameter type | |||
| | Could not infer type for parameter _$1 of anonymous function | |||
There was a problem hiding this comment.
I wonder if it would be possible to report
Could not infer type for the 1st parameter of an anonymous function
There was a problem hiding this comment.
I think it would be possible, but I'm not sure it's desirable, I think here we need to show some internals
There was a problem hiding this comment.
The internal names of _ and other unamed variables are only useful to us. Never to the user as they cannot use them in the source.
There was a problem hiding this comment.
I agree, but we need to show the desugarring anyways, as the issue might be that the user missunderstood how _ works
And therefore need names in the desugarring (but these could be something else than _$1)
nicolasstucki
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed the issue, as well as hopefully improved the existing error
Done with @sankalpgambhir