Simplify tests with custom args in CompilationTests #18376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
simplify-custom-args-tests
branch
from
b1ecef2
to
289fdb8
Compare
som-snytt
reviewed
Aug 10, 2023
| @@ -1,3 +1,5 @@ | |||
| // scalac: -Xfatal-warnings | |||
There was a problem hiding this comment.
Not a zealot (much), but -Werror is more sleek and modern.
Possible warning options include:
-Wconf Configure compiler warnings.
-Werror Fail the compilation if there are any warnings.
My missed opportunity today on a scala 2 PR, for which I am overcompensating:
There was a problem hiding this comment.
Given the size of this PR I prefer to keep all flags identical. We can refactor the flags after this PR.
|
The only flag modification I did was to add |
dwijnand
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.