Splice hole with this capture #18385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
splice-hole-with-this-capture
branch
from
7d4f934
to
d9b7911
Compare
nicolasstucki
force-pushed
the
splice-hole-with-this-capture
branch
from
d9b7911
to
3f78147
Compare
smarter
reviewed
Aug 16, 2023
| @@ -203,6 +203,9 @@ class PickleQuotes extends MacroTransform { | |||
| private def getPicklableHoleType(tpe: Type, isStagedClasses: Symbol => Boolean)(using Context) = | |||
| new TypeOps.AvoidMap { | |||
| def toAvoid(tp: NamedType) = !isStagedClasses(tp.typeSymbol) && !isStaticPrefix(tp) | |||
| override def apply(tp: Type): Type = tp match | |||
| case tp: ThisType if tp.typeSymbol.isLocal => super.apply(tp.widen) | |||
There was a problem hiding this comment.
In regular AvoidMaps this isn't needed:
https://github.com/lampepfl/dotty/blob/ca6a80e3c7aef6b16304df20544c41a96556c834/compiler/src/dotty/tools/dotc/core/TypeOps.scala#L478-L482
Can you add a comment explaining why we need to do something different here?
nicolasstucki
force-pushed
the
splice-hole-with-this-capture
branch
from
3f78147
to
fb02cfc
Compare
smarter
reviewed
Aug 17, 2023
Comment on lines
+211
to
+213
| // However, as we may be extracting a splice that contains a reference to | ||
| // a local class, we need to be careful to avoid the ThisType of the local | ||
| // class. |
There was a problem hiding this comment.
I guess I still don't really understand why we need to do this, what do we do with this approximated type exactly? What happens if we just use Any as an approximation?
nicolasstucki
force-pushed
the
splice-hole-with-this-capture
branch
from
fb02cfc
to
5877755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles two similar but distinct issues in two different phases of the staging process.
refBindingMapforthiswas inconsistent. The mapping did not distinguish between athistype andthisterm because they have the same symbol. The solution is to split the mapping into types and terms.thistype from term. We use aEXPLICITtpt(as in Splice hole with singleton captures #18357) to make sure aThisTypeis unpickled as a type.Revisit #17138