Skip to content

Conversation

@nicolasstucki
Copy link
Contributor

Tests the fixes in #19603. Follow-up of #19586.

Tests scala3-bootstrapped/testCompilation i3, this is a subset that currently works and use to fail.


- name: Test with Scala 2 library with CC TASTy (fast)
run: ./project/scripts/sbt "scala2-library-cc/compile; scala2-library-cc-tasty/compile" # TODO test all the test configurations in non-CC library (currently disabled due to bug while loading the library)
run: ./project/scripts/sbt "scala2-library-cc/compile; scala2-library-cc-tasty/compile; scala3-bootstrapped/testCompilation i3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is i3? Is that a set of test files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues from i3000 to i3999 (i300 to i399, ...) that have compilation tests. It is just a subset of tests that happens to not be contained in #19586 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK.


- name: Test with Scala 2 library with CC TASTy (fast)
run: ./project/scripts/sbt "scala2-library-cc/compile; scala2-library-cc-tasty/compile" # TODO test all the test configurations in non-CC library (currently disabled due to bug while loading the library)
run: ./project/scripts/sbt "scala2-library-cc/compile; scala2-library-cc-tasty/compile; scala3-bootstrapped/testCompilation i3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK.

@odersky odersky merged commit c6a0360 into scala:main Feb 5, 2024
@odersky odersky deleted the enable-scala2-library-cc-tasty-tests branch February 5, 2024 12:36
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants