Skip to content

Bump JLine 3.19.0 -> 3.24.1 & sbt 1.9.7 -> 1.9.9 #19744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Bump JLine 3.19.0 -> 3.24.1 & sbt 1.9.7 -> 1.9.9 #19744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2212fa
Bump JLine to 3.19.0 -> 3.24.1
hamzaremmal Feb 20, 2024
29461f4
Bump sbt from 1.9.7 to 1.9.9
hamzaremmal Feb 24, 2024
b7696fa
Update Coursier test
hamzaremmal Feb 25, 2024
adc2205
Bump JLine to 3.24.1-> 3.25.1
hamzaremmal Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/test-coursier/dotty/tools/coursier/CoursierScalaTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class CoursierScalaTests:

def emptyArgsEqualsRepl() =
val output = CoursierScalaTests.csScalaCmd()
assertTrue(output.mkString("\n").contains("Unable to create a system terminal")) // Scala attempted to create REPL so we can assume it is working
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack trace with JLine 3.19.0:

Exception in thread "main" java.lang.IllegalStateException: Unable to create a system terminal
	at org.jline.terminal.TerminalBuilder.doBuild(TerminalBuilder.java:323)
	at org.jline.terminal.TerminalBuilder.build(TerminalBuilder.java:265)
	at dotty.tools.repl.JLineTerminal.<init>(JLineTerminal.scala:25)
	at dotty.tools.repl.ReplDriver.runUntilQuit(ReplDriver.scala:144)
	at dotty.tools.repl.ReplDriver.tryRunning(ReplDriver.scala:135)
	at dotty.tools.repl.Main$.main(Main.scala:7)
	at dotty.tools.MainGenericRunner$.run$1(MainGenericRunner.scala:193)
	at dotty.tools.MainGenericRunner$.process(MainGenericRunner.scala:270)
	at dotty.tools.MainGenericRunner$.main(MainGenericRunner.scala:281)
	at dotty.tools.MainGenericRunner.main(MainGenericRunner.scala)

assertTrue(output.mkString("\n").contains("Unable to create a terminal")) // Scala attempted to create REPL so we can assume it is working
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack trace with JLine 3.24.1:

Exception in thread "main" java.lang.IllegalStateException: Unable to create a terminal
	at org.jline.terminal.TerminalBuilder.doBuild(TerminalBuilder.java:394)
	at org.jline.terminal.TerminalBuilder.build(TerminalBuilder.java:362)
	at dotty.tools.repl.JLineTerminal.<init>(JLineTerminal.scala:25)
	at dotty.tools.repl.ReplDriver.runUntilQuit(ReplDriver.scala:144)
	at dotty.tools.repl.ReplDriver.tryRunning(ReplDriver.scala:135)
	at dotty.tools.repl.Main$.main(Main.scala:7)
	at dotty.tools.MainGenericRunner$.run$1(MainGenericRunner.scala:193)
	at dotty.tools.MainGenericRunner$.process(MainGenericRunner.scala:270)
	at dotty.tools.MainGenericRunner$.main(MainGenericRunner.scala:281)
	at dotty.tools.MainGenericRunner.main(MainGenericRunner.scala)
	Suppressed: java.io.IOException: Unable to find terminal provider ffm
		at org.jline.terminal.spi.TerminalProvider.load(TerminalProvider.java:74)
		at org.jline.terminal.TerminalBuilder.checkProvider(TerminalBuilder.java:665)
		at org.jline.terminal.TerminalBuilder.getProviders(TerminalBuilder.java:630)
		at org.jline.terminal.TerminalBuilder.doBuild(TerminalBuilder.java:395)
		... 9 more
	Suppressed: java.io.IOException: Unable to find terminal provider jni
		at org.jline.terminal.spi.TerminalProvider.load(TerminalProvider.java:74)
		at org.jline.terminal.TerminalBuilder.checkProvider(TerminalBuilder.java:665)
		at org.jline.terminal.TerminalBuilder.getProviders(TerminalBuilder.java:632)
		at org.jline.terminal.TerminalBuilder.doBuild(TerminalBuilder.java:395)
		... 9 more
	Suppressed: java.io.IOException: Unable to find terminal provider jansi
		at org.jline.terminal.spi.TerminalProvider.load(TerminalProvider.java:74)
		at org.jline.terminal.TerminalBuilder.checkProvider(TerminalBuilder.java:665)
		at org.jline.terminal.TerminalBuilder.getProviders(TerminalBuilder.java:634)
		at org.jline.terminal.TerminalBuilder.doBuild(TerminalBuilder.java:395)
		... 9 more

emptyArgsEqualsRepl()

def run() =
Expand Down Expand Up @@ -133,7 +133,7 @@ class CoursierScalaTests:

def replWithArgs() =
val output = CoursierScalaTests.csScalaCmd("-source", "3.0-migration")
assertTrue(output.mkString("\n").contains("Unable to create a system terminal")) // Scala attempted to create REPL so we can assume it is working
assertTrue(output.mkString("\n").contains("Unable to create a terminal")) // Scala attempted to create REPL so we can assume it is working
replWithArgs()

def argumentFile() =
Expand Down
6 changes: 3 additions & 3 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,9 +624,9 @@ object Build {
libraryDependencies ++= Seq(
"org.scala-lang.modules" % "scala-asm" % "9.6.0-scala-1", // used by the backend
Dependencies.compilerInterface,
"org.jline" % "jline-reader" % "3.19.0", // used by the REPL
"org.jline" % "jline-terminal" % "3.19.0",
"org.jline" % "jline-terminal-jna" % "3.19.0", // needed for Windows
"org.jline" % "jline-reader" % "3.25.1", // used by the REPL
"org.jline" % "jline-terminal" % "3.25.1",
"org.jline" % "jline-terminal-jna" % "3.25.1", // needed for Windows
("io.get-coursier" %% "coursier" % "2.0.16" % Test).cross(CrossVersion.for3Use2_13),
),

Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.9.7
sbt.version=1.9.9