Skip to content

Add checkfile for ScalaCheck #20388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2024
Merged

Add checkfile for ScalaCheck #20388

merged 1 commit into from
May 11, 2024

Conversation

hamzaremmal
Copy link
Member

[test_scala2_library_tasty]

Closes #20374

@hamzaremmal hamzaremmal self-assigned this May 11, 2024
| ├── object FirstParser extends CmdLineParser: [ ScalaCheck.scala:15 ]
| │ ^
| └── val opts = List(OptMinSuccess) [ ScalaCheck.scala:21 ]
| ^^^^^^^^^^^^^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I introduced the problem. As a quick fix, you can change List to Some in the original test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, it is indeed working locally with the scala2_library_tasty

@hamzaremmal hamzaremmal marked this pull request as ready for review May 11, 2024 19:53
@hamzaremmal hamzaremmal requested a review from liufengyun May 11, 2024 19:54
@hamzaremmal hamzaremmal enabled auto-merge May 11, 2024 19:54
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of it @hamzaremmal !

@hamzaremmal
Copy link
Member Author

Thank you for taking care of it @hamzaremmal !

No worries, but I would very much suggest opening a ticket to track the original bug

@liufengyun
Copy link
Contributor

No worries, but I would very much suggest opening a ticket to track the original bug

It's an issue well known to us, tracked by #18882. We are actively working on it.

@hamzaremmal
Copy link
Member Author

It's an issue well known to us, tracked by #18882. We are actively working on it.

Oh, I missed this ticket. Good luck !

@hamzaremmal
Copy link
Member Author

@liufengyun the CI failed again eventhough it worked for me locally. I will disable the test for now and you can always enbale it later when the fix is ready

@hamzaremmal hamzaremmal merged commit 362b075 into scala:main May 11, 2024
16 of 17 checks passed
@hamzaremmal hamzaremmal deleted the i20374 branch May 11, 2024 21:12
liufengyun added a commit that referenced this pull request May 12, 2024
I forgot that I enabled auto-merge in #20388 . The fix, eventhought it
worked locally, didn't pass the CI. For now, this is a very quick fix
(or more disabling the test) to fix the CI

[test_scala2_library_tasty]
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2024-05-10 failed
3 participants