-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add checkfile for ScalaCheck #20388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkfile for ScalaCheck #20388
Conversation
| ├── object FirstParser extends CmdLineParser: [ ScalaCheck.scala:15 ] | ||
| │ ^ | ||
| └── val opts = List(OptMinSuccess) [ ScalaCheck.scala:21 ] | ||
| ^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I introduced the problem. As a quick fix, you can change List
to Some
in the original test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, it is indeed working locally with the scala2_library_tasty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of it @hamzaremmal !
No worries, but I would very much suggest opening a ticket to track the original bug |
It's an issue well known to us, tracked by #18882. We are actively working on it. |
Oh, I missed this ticket. Good luck ! |
@liufengyun the CI failed again eventhough it worked for me locally. I will disable the test for now and you can always enbale it later when the fix is ready |
I forgot that I enabled auto-merge in #20388 . The fix, eventhought it worked locally, didn't pass the CI. For now, this is a very quick fix (or more disabling the test) to fix the CI [test_scala2_library_tasty]
[test_scala2_library_tasty]
Closes #20374