Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Avoid crash arising from trying to find conversions from polymorphic singleton types" to LTS #20740

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Backport "Avoid crash arising from trying to find conversions from polymorphic singleton types" to LTS #20740

merged 2 commits into from
Jun 23, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #18760 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@odersky @WojciechMazur
Avoid crash arising from trying to find conversions from polymorphic …
e90d376 
…singleton types

This is an alternative fix for #18695, which already got fixed in a different way by #18719.
This PR adds the actual tests, and leaves in the fix as a defensive measure in case the situation
arises by some other means than the one foxed in #18719.

[Cherry-picked f995a8c]
@odersky @WojciechMazur
Add test cases
a27caa4 
[Cherry-picked 125612f]
Base automatically changed from lts-18759 to lts-3.3 June 23, 2024 22:40
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-19083.

Reference

@WojciechMazur WojciechMazur merged commit 8f7b8a7 into lts-3.3 Jun 23, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-18760 branch June 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @odersky